-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update TPG version constraints to 4.0 #1129
Conversation
Thanks for the PR! 🚀 |
596bcbb
to
0dccbb7
Compare
* addresses warning about multiple provider blocks
* fetches main branch by default?
* temporary change until new version is released
* temporary change until new version of that dependency is released
* this should be removed once hashicorp/terraform-provider-google#10494 is addressed
0dccbb7
to
2d8e5eb
Compare
@@ -112,6 +112,7 @@ resource "google_compute_firewall" "master_webhooks" { | |||
direction = "INGRESS" | |||
|
|||
source_ranges = [local.cluster_endpoint_for_nodes] | |||
source_tags = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround for hashicorp/terraform-provider-google#10494. Long term fix maybe GoogleCloudPlatform/magic-modules#5526 but will need to validate.
@morgante PTAL since I rebased this and added a few commits |
} | ||
``` | ||
|
||
### Acceptable values for node_metadata modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of requiring users to change this, I think we can provide a mapping at very low effort to ourselves. Could you add that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the doc in e83bfc3 to make this a recommendation instead, encouraging users to switch to values that are supported by the provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits - go ahead and merge once resolved.
Co-authored-by: Morgante Pell <morgantep@google.com>
…s#1129) * feat: update TPG version constraints to allow 4.0 * Removes basic auth, renames namespace_identity * Regenerates modules and documentation * Updates tests to use latest Google provider * addresses warning about multiple provider blocks * Updates network module for Google provider 4.0 compatibility * Temporarily uses "main" for gcloud module (until next release is cut) * Comments out version constraint (temporary change) * fetches main branch by default? * Uses master branch for gcloud module (until release is cut) * Uses kubectl-wrapper where appropriate * Uses released version of gcloud module * Returns instance group URLs per node pool * Extends use of cluster_output_node_pools_ variables * Fixes documentation * Updates more modules * Updates READMEs to match variables * Uses master branch of bastion * temporary change until new version is released * Updates node pools versions description * Adds locals for node pool instance group URLs * Uses master branch of terraform-google-project-factory * temporary change until new version of that dependency is released * Updates project version ready for release * Updates pinned version of Google provider for example * Updates pinned version of Google provider in example * Addresses code review comments * Temporarily applies an empty source_tags setting. * this should be removed once hashicorp/terraform-provider-google#10494 is addressed * Fixes indentation * Uses newly-released version of project factory * Uses released version of bastion host * Removes use of SECURE mode (deprecated) * test empty source tag workaround * fix wi test * refactor IAM test for loose match * map old node meta value, add validations * update docs * Update autogen/main/variables.tf.tmpl Co-authored-by: Morgante Pell <morgantep@google.com> * remove local Co-authored-by: cloud-foundation-bot <cloud-foundation-bot@google.com> Co-authored-by: Jack Whelpton <jack.whelpton@rakuten.com> Co-authored-by: Morgante Pell <morgantep@google.com>
based off of #1071 since I didnt have permission to push to the fork branch